First Last Prev Next    No search results available
Details
: Gmetad is not storing the extra data correctly
Bug#: 188
: Ganglia Monitoring System
: gmetad
Status: RESOLVED
Resolution: FIXED
: All
: All
: 3.1.x
: P2
: critical

:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Brad Nicholes <bnicholes@novell.com>
Assigned To: Brad Nicholes <bnicholes@novell.com>
:

Attachments
Add each extra data individually (3.22 KB, text/x-patch)
2008-05-13 14:59, Brad Nicholes
Details
Add each extra data element individually (3.22 KB, patch)
2008-05-13 15:06, Brad Nicholes
Details
backported fix for ganglia 3.1 (481 bytes, patch)
2008-08-08 01:18, Carlo Marcelo Arenas Belon
Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2008-05-13 14:57
The is actually a 3.1.x bug.

When the extra data is stored in the hash table for each metric, the extra 
data strings are being overwritten.  The extra data needs to be added to each 
summary metric rather than trying to replace the entire strings field.
------- Comment #1 From Brad Nicholes 2008-05-13 14:59:40 -------
Created an attachment (id=131) [details]
Add each extra data individually
------- Comment #2 From Brad Nicholes 2008-05-13 15:00:42 -------
This has been fixed in trunk.  The attached patch is against the 3.1 branch is
has been proposed for backport
------- Comment #3 From Brad Nicholes 2008-05-13 15:06:22 -------
Created an attachment (id=132) [details]
Add each extra data element individually
------- Comment #4 From Carlo Marcelo Arenas Belon 2008-08-03 22:35:35 -------
this was fixed for 3.1.0 AFAIK
------- Comment #5 From Brad Nicholes 2008-08-04 07:52:53 -------
Fixed in Trunk and backported to the 3.1 branch.
------- Comment #6 From Carlo Marcelo Arenas Belon 2008-08-06 11:10:22 -------
seems like an incomplete fix was backported in this bug by :

r1355 | bnicholes | 2008-05-16 12:46:01 -0700 (Fri, 16 May 2008) | 7 lines

Add each extra data element individually to the summary metric node
rather than replacing the entire strings field. This also resolves a
memory leak issue while processing the metric XML data.

Reviewed by: bnicholes, bernardli

it has been reported though later that the same code will segfault while used by
an aggregator as detailed in :

http://www.mail-archive.com/ganglia-developers@lists.sourceforge.net/msg04584.html
------- Comment #7 From Brad Nicholes 2008-08-07 08:56:10 -------
This was a problem with process the tag when gmetad is not the authority.  A
fix
has been committed to trunk (#1633) and proposed for backport.
------- Comment #8 From Carlo Marcelo Arenas Belon 2008-08-08 01:18:05 -------
Created an attachment (id=151) [details]
backported fix for ganglia 3.1

First Last Prev Next    No search results available