First Last Prev Next    No search results available
Details
: node_image for dead node shows healthy icon
Bug#: 214
: Ganglia Monitoring System
: web frontend
Status: ASSIGNED
Resolution:
: PC
: Linux
: 3.0.x
: P2
: minor
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Noah Silas <noah.silas@email.ucr.edu>
Assigned To: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
:

Attachments
Proposed Patch (651 bytes, patch)
2008-10-08 11:07, Noah Silas 		Details
Updated patch (373 bytes, patch)
2008-10-08 14:35, Bernard Li 		Details
Hide Obsolete (1) | View All Add an attachment (proposed patch, testcase, etc.)


Note

You need to log in before you can comment on or make changes to this bug.

Related actions

Description:   Opened: 2008-10-08 11:04 
When looking at a host_view for a node that is down, node_image will return a
reference to node_0-24.jpg instead of node_dead.jpg.  This puts a misleading
icon on the page.
------- Comment #1 From Noah Silas 2008-10-08 11:07:59 ------- 
Created an attachment (id=171) [details]
Proposed Patch
------- Comment #2 From Bernard Li 2008-10-08 14:34:22 ------- 
Thanks for the bug report Noah, however I think all we need to do is add
"global
$hosts_down;" in the node_image() function.
------- Comment #3 From Bernard Li 2008-10-08 14:35:10 ------- 
Created an attachment (id=172) [details]
Updated patch
------- Comment #4 From Noah Silas 2008-10-08 14:42:05 ------- 
Ah - you're right.  When I was testing I mistakenly looked at a healthy node,
so
$hosts_down wasn't set!  Oops!
------- Comment #5 From Bernard Li 2008-10-13 13:00:24 ------- 
Patch checked into trunk r1852, backported to 3.1.x r1863.

Closing issue -- can be re-opened if backport to 3.0.x is desired.
First Last Prev Next    No search results available